SEZ9 commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-6514066867
Thanks for the detailed re-check against head `4b80eba2519f8a1d13a54229dbd2090d7fca8a9f`. I have not yet confirmed those changes in the diff myself, so I'm leaving F1–F8 open until I do rather than closing them from the description alone. To speed up that pass, it would help if the PR author could point me to the relevant hunks for: - F1 / F5 (`start-seatunnel-spark-3.5-connector-v2.cmd`): where the java exit code is captured and propagated, and how the empty-stdout case now fails rather than exiting 0. - F2 / F6 (`start-seatunnel-spark-3.5-connector-v2.sh`): the argument handling that replaced `eval` and the unquoted `args`/`CLASS_PATH` usage. - F4 (`seatunnel-core/seatunnel-spark-starter/pom.xml`): the logging-jar include/exclude change and the test that asserts a single SLF4J binding. - F3 (`seatunnel-spark-3.5-starter/pom.xml`): the docs wording that explicitly names Spark 3.5 when describing the remaining Catalyst validation limits of the reused 3.3 translation layer. - F7 (`docs/en/getting-started/locally/quick-start-spark.md`): confirmation that the quick-start page no longer sends Spark 3.5 users to the streaming template, plus the bounded micro-batch test that runs against 3.5.8. - F8 (`docs/en/engines/spark.md`): the retained Spark 3.4.x guidance. On CI: `Build` = `FAILURE` and `Signal pull request update` = `SUCCESS`. The `No tests were executed` stop in `seatunnel-resource-managers-e2e` and the cancelled connector/file shards don't appear related to the launcher/POM/doc items above, so I agree the Spark launcher should not be changed speculatively to chase that. Those jobs still need to be green (or shown to be a pre-existing dev issue) before merge, but that's outside this review's scope. Once I've read the head against the points above, I'll post a final pass. <!-- streview-comment:2142 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
