DanielLeens commented on PR #12944: URL: https://github.com/apache/seatunnel/pull/12944#issuecomment-6514210942
Thanks @SEZ9. I can read the complete replies through the API, so no additional repost is needed for my review. On this exact head, `MetadataProviderManager.java:294-306` already documents datasource-over-job precedence and key quoting, and `docs/en/introduction/concepts/metadata-spi.md:375` states the same precedence. Those documentation points and the fixture-only assertions were covered in my latest full review. +1 on the remaining prerequisite: #12443 is still OPEN, and the exact-head unit/engine CI now directly reports `cannot find symbol: ConfigMapPathUtils` at `MetadataProviderManager.java:27`. The job named Dependency licenses also stops on compilation, not on a license-appendix mismatch. The latest dev license fix does not supply that missing helper. Please wait for #12443 to land, update this branch onto the merged helper, then run standalone metadata UT/Metalake IT CI and record the prerequisite revision. A simple sync before that prerequisite lands will not fix it; do not add a competing helper or unrelated dependency here. The whole-job short-circuit remains an explicitly deferred follow-up. Snapshot 2026-10-30T03:23:54.122998+00:00: head `351826ab6daad84488235768464a73dfa1a1b051`; [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40860578042/job/123852205318) = `SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/123861670741) = `FAILURE`. Base `dev`; comparison `diverged`, ahead 5, behind 4; merge state `blocked`. Behind/diverged alone is recorded metadata and does not add a sync request. This is an unchanged-head discussion/CI clarification, not a new complete source review, an effective approval or a dismissal of historical requested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
