fatmanverse commented on PR #12920: URL: https://github.com/apache/seatunnel/pull/12920#issuecomment-6515608667
Thanks @DanielLeens. Addressed in ddd0878b3. **Issue 1 (SQL transform IT).** `sql_transform/func_system.conf`, run by `TestSQLIT`, now has a STRING and a `decimal(10,2)` column for each of `1.21` and `-1.25`, cast to `DECIMAL(10,1)`: | source | value | expected | old CEILING result | |---|---|---|---| | STRING | `1.21` | `1.2` | `1.3` | | STRING | `-1.25` | `-1.3` | `-1.2` | | DECIMAL(10,2) | `1.21` | `1.2` | `1.3` | | DECIMAL(10,2) | `-1.25` | `-1.3` | `-1.2` | So all four assertions fail with the old rounding. The existing `12.4 -> DECIMAL(10,2)` case is unchanged. Verified on JDK 17: `TestSQLIT` 32 run, 0 failures across the Flink, Spark and Zeta containers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
