DanielLeens commented on PR #12871: URL: https://github.com/apache/seatunnel/pull/12871#issuecomment-6537987808
Thanks @nzw921rx. If you mean more than 17 significant decimal digits, one concrete case is ARRAY<DECIMAL(38,20)> containing the JSON number 3.14159265358979323846. High-precision financial amounts, rates or measurements can also legitimately use DECIMAL precision beyond binary double precision. The defect is converting the JSON token to double before BigDecimal: the discarded digits cannot then be recovered. It is not a count of people or array elements, and 17 is not a universal safe cutoff for exact decimal values. The existing regression checks exact BigDecimal values through the public deserializer. My source conclusion remains clear; current CI is green. Checked 2026-10-31T02:46:50.946216+00:00; unchanged head `92ca48dba98a71231a85b6bc990a6d65aef39a74`. [Label PRs when reviewed](https://github.com/apache/seatunnel/actions/runs/41007283151/job/123904948059)=`SUCCESS`; [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40201305643/job/121192870759)=`SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/123172256446)=`SUCCESS`. This is a discussion/CI clarification, not another full source review or an effective maintainer approval. Daniel has READ repository permission; a write-capable maintainer owns required approval/dismissal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
