Rangsh commented on PR #12081:
URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6514217516

   @SEZ9 These are already on `8f2f6fa98`.
   
   - F2: `WALWorkHandler` catches `Exception` around the write and 
`executeResponse()` (L111–140).
   - F4: the first write failure sets `appendBlockedAfterWriteFailure` 
(L111–113); later APPENDs return at L99 without touching the writer. Pinned by 
`WALWorkHandlerSurvivabilityTest` L132–184.
   - F6: one shared `deadlineNanos` for `storeAll` / `deleteAll` 
(`IMapFileStorage` L352–377).
   - F1/F3: no production caller uses untimed `get()`. Timed `get(long, 
TimeUnit)` throws `TimeoutException` and returns the actual `Boolean` 
(`RequestFuture` L57–90).
   - F5: `mockito-junit-jupiter` was added test-scoped in `26ce5cb26` 
(`imap-storage-file/pom.xml` L76–80). `HdfsWriterFlushSyncPathTest` is now 
`HdfsWriterFlushCallCountTest`.
   - F7: `@throws TimeoutException` is on `get(long, TimeUnit)` itself.
   - F8: one WARN line per timeout (requestId / elapsed / limit), stack at 
DEBUG; ERROR only for the unexpected branch 
(`IMapFileStorage.queryExecuteStatus` L331–345).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to