DanielLeens commented on PR #12081: URL: https://github.com/apache/seatunnel/pull/12081#issuecomment-6514221970
Thanks @SEZ9. I checked the exact-head pointers rather than asking for another status table. RequestFuture.java:57-67 explicitly limits untimed get() to Future compliance; the storage call sites use the timed overload. Its timed contract is documented at :70-89 and returns the actual success Boolean. imap-storage-file/pom.xml:87-89 explicitly declares mockito-junit-jupiter in test scope. IMapFileStorage.java:365-375 treats timeout at WARN with requestId/elapsed/limit, with the stack at DEBUG and unexpected exceptions at ERROR. Those earlier F1-F8 points were reconciled in my last full review. The remaining requests are that review's engine persistence integration and bilingual fail-loud operational guidance, plus its nonblocking deadline-test/stream-cleanup corrections. CI has now completed red in unit-test (11): SavePointTest.testSavePointButJobGoingToFail expected DOING_SAVEPOINT but observed FAILED. Latest dev has no corresponding merged SavePointTest fix, so a simple sync is n ot an established cure; preserve the exact failed-job diagnostics rather than treating CI as proof the remaining recovery coverage is unnecessary. Snapshot 2026-10-30T03:23:54.162383+00:00: head `8f2f6fa986b04ef3f96315dcf722a282357d744d`; [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40864785509/job/123852183704) = `SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/123860691341) = `FAILURE`. Base `dev`; comparison `diverged`, ahead 19, behind 3; merge state `blocked`. Behind/diverged alone is recorded metadata and does not add a sync request. This is an unchanged-head discussion/CI clarification, not a new complete source review, an effective approval or a dismissal of historical requested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
