wgzhao commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6593705264
@SEZ9 all four are already addressed on `fb542b3e9`. This push only touched `seatunnel-cli/tests/test_diagnose_cli.py` (`git diff 4cfc9b02b..fb542b3e9` shows one file), so the docs/SDK/UI pointers from the `4cfc9b02b` walkthrough still apply unchanged. - **F1/F3** — all four EN/ZH REST sections document the marker: v1 `/hazelcast/rest/maps/job-info/:jobId` (en `rest-api-v1.md:402,430`; zh `:422,448`), v1 `/hazelcast/rest/maps/running-job/:jobId` (en `:520,524`; zh `:514,518`), v2 `/job-info/:jobId` (en `rest-api-v2.md:678,721`; zh `:669,709`), and the deprecated v2 `/running-job/:jobId`, which keeps its deprecation header (en `:741`) and carries the unknown-id example at `:809-820` before linking back to `/job-info` at `:822`. Addressed on this head, not deferred. - **F5** — the post-submit polling path no longer says "the id may be wrong": both the `found: false` branch and the repeated status-less branch describe a removed/expired job and point at the master logs (`cli.py:1375-1396`). The only remaining "id may be wrong" wording is the user-supplied-id 404 branch in `run_diagnose` (`cli.py:1659`). Addressed, not deferred. - **F6/F8** — an initial-load rejection renders the error card (`detail.tsx:139-146`, rendered at `:613-618`); a post-load rejection keeps the populated page, warns once per error streak and retries on the next tick, with `lastRefreshError` reset on success (`:122`, `:148-153`); the not-found card renders the requested `jobId` (`:617`, asserted at `detail.spec.ts:187-188`). Addressed, not deferred. - **F7** — `JobsApi.job_exists` raises `TypeError` for a non-dict/non-JSON body before checking `found` (`jobs.py:99-103`), covered by `test_job_exists_rejects_non_json_response` (`test_sdk.py:148`). Addressed, not deferred. On the cut-off comment: the full ending is "...the PR is back to `REVIEW_REQUIRED` and a fresh committer approval will be needed after your recheck." That was its last sentence — there was no further ask; only the email notification truncated it. Head is still `fb542b3e9`, so the F1–F8 recheck can run against it as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
