DanielLeens commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6537993273
Thanks @wgzhao and @SEZ9. Build is now SUCCESS on the unchanged reviewed head, so my earlier Doris-startup retry request is superseded and my CI objection is cleared. I checked the three follow-up points in source: - CLI: test_polling_stops_when_the_job_is_not_known in test_diagnose_cli.py:330-358 asserts one call for found:false and two for repeated status-less responses; test_polling_recovers_from_one_status_less_response at :361-380 covers recovery to FINISHED. cli.py:1400 resets missing_response_seen on a valid status, and the explicit found:false branch runs before shape handling. I did not find a dedicated non-dict-then-found:false test or a status-less/good/status-less sequence in that fixture, so I am not claiming those exact sequences are tested. - UI: detail.tsx:121 resets lastRefreshError after a good status. src/tests/detail.spec.ts:344-403 explicitly covers repeated rejection, a successful refresh, then rejection again, and asserts warning counts 1, 1, 2, 2, 3. This test already exists on the reviewed head. - Docs: the deprecated v2 running-job section carries the deprecation note at rest-api-v2.md:741, and its found:false example at :813-823 links back to job-info. The example remains inside that deprecated section. My existing source conclusion remains clear. These pointers should help the independent reviewer complete the requested recheck without treating already-present UI coverage as missing; @SEZ9 can separately resolve the specific additional CLI coverage request. Checked 2026-10-31T02:47:20.919081+00:00; unchanged head `4cfc9b02bfee4a326e042b79e53b7bcfe1fad857`. [Signal pull request update](https://github.com/apache/seatunnel/actions/runs/40668148306/job/122796164552)=`SUCCESS`; [Lint](https://github.com/apache/seatunnel/actions/runs/40668148265/job/122796137351)=`SUCCESS`; [Test with Python 3.9](https://github.com/apache/seatunnel/actions/runs/40668148311/job/122796150654)=`SUCCESS`; [Test with Python 3.13](https://github.com/apache/seatunnel/actions/runs/40668148311/job/122796150129)=`SUCCESS`; [Test with Python 3.10](https://github.com/apache/seatunnel/actions/runs/40668148265/job/122796137589)=`SUCCESS`; [Test with Python 3.13](https://github.com/apache/seatunnel/actions/runs/40668148265/job/122796137726)=`SUCCESS`; [Build](https://github.com/apache/seatunnel/runs/123923768320)=`SUCCESS`. This is a discussion/CI clarification, not another full source review or an effective maintainer approval. Daniel has READ repository permission; a write-capable maintainer owns required approval/dismissal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
