wgzhao commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6552225177
All verified against the unchanged head `4cfc9b02b`. Items 2–3 below were in my previous comment, but the notification email appears to have truncated it — please check the full text on the GitHub page. - **F1/F3** — `found: false` is documented for v1 `job-info`, v1 `running-job`, deprecated v2 `running-job` and v2 `job-info` in both EN/ZH docs; the deprecated v2 section keeps its deprecation header (`rest-api-v2.md:741`) and its `found: false` example (`:813-823`) links back to `/job-info`. - **F2/F4** — `found: false` stops on the first poll, one status-less body is tolerated and a second ends with the response-shape message (`test_diagnose_cli.py:339-379`); `missing_response_seen` resets only after a valid `jobStatus` (`cli.py:1398`). No dedicated test for non-dict→`found:false` or status-less→good→status-less — I can pin both in the same test if you want them covered. - **F5** — no longer applies to ids the CLI got from `/submit-job`; the only "id may be wrong" text is the user-supplied-id HTTP 404 branch in `run_diagnose` (`cli.py:1659`). - **F6/F8** — initial-load rejection renders the error card; a post-load rejection keeps the populated page, warns once per streak and retries, with `lastRefreshError` reset on success (`detail.tsx:122`; reject→success→reject covered at `detail.spec.ts:344-403`); the not-found state renders the requested id (`detail.tsx:616`, asserted at `detail.spec.ts:187-188`). - **F7** — `JobsApi.job_exists` raises `TypeError` on a non-dict/non-JSON body before checking `found` (`jobs.py:100`, covered at `test_sdk.py:148-158`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
