SEZ9 commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6816753560
@wgzhao thanks for the detailed walkthrough of the polling behaviour and for the pointers to the scripted-response tests. **F2 / F4:** Your description — `found: false` is immediately terminal, a single status-less or non-dict 200 is tolerated once, the second consecutive one yields the response-shape/failover message rather than a "job not known" verdict, transport exceptions neither increment nor reset the flag, and a valid `jobStatus` resets it — would address both findings. I have not yet re-read the cited lines and tests myself at `fb542b3e9`, so I'm keeping F2/F4 open until I've done that; if the source matches what you describe, I'll close both as not-a-bug with no code change needed. **F5:** Thanks for the correction — the removed/expired wording being confined to the `found: false` branch, with the repeated status-less branch printing the response-shape/failover message, is clearer than I had understood. The only remaining part of F5 is the "The id may be wrong" phrasing for an id the CLI itself just received from `/submit-job`. If you'd rather keep it, a one-line rationale is fine and I'll close it. **Remaining points from the earlier review** (please just confirm either way): - F1 / F3: will the `found: false` payload be documented for the v1 endpoints and the deprecated `/running-job/:jobId`, or is that left for a follow-up? - F6 / F8: are the UI `fetch` error path and showing the looked-up job id in the "Job not found" state in scope here or deferred? - F7: is `JobsApi.job_exists` returning `False` for a non-dict payload intentional? If so, a short docstring note would be enough. Once I have your answers and have finished re-checking F2/F4, I'll do the final pass. <!-- streview-comment:2278 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
