SEZ9 commented on PR #12904: URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6841660928
@wgzhao thanks for the detailed walkthrough; noted that the head is unchanged at `fb542b3e9`. **F2/F4** — The `_poll_job_status` behaviour you describe (explicit `found: false` terminal immediately, one status-less/non-dict body tolerated, the second consecutive one reported as a response-shape/master-failover problem rather than "job is not known", a valid `jobStatus` resetting the flag, transport exceptions neither incrementing nor resetting it) is what I was asking for, and keeping the one-shot `diagnose` path without tolerance makes sense. I'll confirm the implementation and the named scripted-sequence tests against the diff at `fb542b3e9` and then close both. **F5** — If the "id may be wrong" wording only lives in the `run_diagnose` HTTP 404 branch, where the id is user-supplied, the hint is accurate there and I'll close F5 as not-applicable once I've verified the poller contains no such text. **F1/F3** — Thanks for the EN/ZH pointers for the v1 `/job-info`, v1 `/running-job`, and deprecated v2 `/running-job` handlers. I'll check that each of those sections now shows the `found: false` payload and close both if so. **F6/F8** — Your comment appears to be cut off after "the catch sets `loadError` before the first success". Could you finish that thought? Specifically: (a) what the detail page renders when `loadError` is set (the non-blank error path for F6), and (b) whether the missing-job state shows the job id that was looked up (F8). A one-line confirmation is enough. **F7** — I didn't see `JobsApi.job_exists` addressed. Is returning `False` for any non-dict payload intentional for the SDK, or do you plan to distinguish a non-JSON response from "job does not exist" the way the CLI poller does? Either is fine with me; I just want the decision explicit. Once F6/F8 and F7 are answered and I've verified the above against the diff, I have nothing else outstanding. <!-- streview-comment:2302 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
