wgzhao commented on PR #12904:
URL: https://github.com/apache/seatunnel/pull/12904#issuecomment-6842341358
@SEZ9 thanks. The previous reply was truncated, so here are just the two
missing answers.
**F6/F8** (`detail.tsx`)
- (a) A failure before the first successful load sets `loadError`
(`:139-146`). The page then renders `renderMissing()` (`:609-619`, gated at
`:793`): an `NResult` with status `error` and
`detail.loadError.title/description`, including `jobId` and the error text. Not
a blank page. After a load has succeeded, a later failure keeps the page and
warns once per error streak (`:147-152`).
- (b) Yes. The not-found card passes `{ jobId }` into
`detail.notFound.description`, so the looked-up id is shown.
**F7** `job_exists` does not return `False` for a non-dict payload. It
raises `TypeError`
(`tools/seatunnel-python-sdk/seatunnel/endpoints/jobs.py:99-103`) before the
`found` check, so "server said absent" and "unexpected response shape" stay
distinct, as in the CLI poller. Covered by `test_sdk.py:148-159`. The docstring
has no `Raises:` note yet; I would add that in a follow-up rather than move the
SHA now.
F1/F3 and F5 are unchanged from my previous reply. Head is still
`fb542b3e9`, CI green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]