SEZ9 commented on PR #12810:
URL: https://github.com/apache/seatunnel/pull/12810#issuecomment-6870329624

   Thanks for the update — I re-reviewed the latest push at 
`c6a6c730920237a0ee1405b0ce42906084beb69e`. The earlier blocker about the bare 
`table_name}` fragment is fixed and the old merge conflict is gone.
   
   **Still blocking**
   
   - **F1 (string vs. list retyping)** — an explicitly quoted argument value 
referenced by a single placeholder is still retyped into a List instead of 
staying a quoted String, which contradicts the documented disambiguation rule. 
The quotes from the argument need to survive so an explicitly quoted value is 
never re-parsed as structured. Please add a unit test covering exactly this 
case alongside the fix.
   
   **Still open (non-blocking)**
   
   - **F5 (quoted default keeps literal quotes)** — the migration notes still 
promise a quoting workaround that fails in the quoted-placeholder path, 
yielding the value with the double quotes included. Either the behavior should 
match the docs or the docs should change; please align both.
   
   I will follow up separately with the diff status of the remaining medium 
points (F2–F4, F6–F8) once I have gone through them. Once F1 is resolved with a 
test, I'm happy to do a final pass.
   
   <!-- streview-comment:2333 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to