SEZ9 commented on PR #12810:
URL: https://github.com/apache/seatunnel/pull/12810#issuecomment-7024990557
Thanks for the update. The quoted `-i` typing fix looks good. Here is where
the previously raised points stand.
**Addressed**
- **Quoted `-i` values:** the new raw-user helper keeps the quote intent for
standalone values in both map and list leaves, so a quoted regex argument
should now remain a String.
**Looks addressed, please confirm**
- **System sink placeholders:** reserved placeholders now appear to pass
through ahead of the duplicate/default checks. Can you confirm that a
multi-sink config mixing `${table_name}` and `${table_name:fallback}` loads
again, ideally with a test?
**Still open**
- **`isStructured` shorthand:** it still requires a depth-one separator, so
valid HOCON object shorthand such as `-i schema='{fields{id=int,name=string}}'`
is demoted to a plain String. Please restore Map injection for this form.
- **Raw values in error messages:** `parseStructured` still exposes the raw
parse input and cause in the exception. Please keep raw default values, raw
`-i` values and surrounding config text out of these messages, since they are
printed before any desensitization runs.
- **Javadoc:** the contract of the new public helpers still needs
documenting. Please make sure `hasOnlyOnePlaceholder`,
`checkNotResolvedDefaultValue` and `parseStructured` have Javadoc, and that the
exception declared in the `processPlaceholders` Javadoc matches the
`ConfigException.BadValue` it throws.
**Status unknown, please tell me**
- **Quoted defaults:** does a quoted default value still keep its literal
double quotes in the resolved option value?
- **`checkNotResolvedDefaultValue`:** does it still swallow every
non-`NotResolved` exception, and does the plain-string branch still report
"Structured default value"?
- **EN config doc:** does the new EN bullet now link to the EN
connector/transform docs, and are the unbalanced `***` and the missing space in
the preceding bullet fixed?
Once the open items are fixed and the questions answered, I'll take another
look.
<!-- streview-comment:2467 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]