SEZ9 commented on PR #12810:
URL: https://github.com/apache/seatunnel/pull/12810#issuecomment-6962345223
Thanks for the update and for reconciling the earlier findings against the
current head.
**Quoted `-i` values.** Agreed on the direction: a quoted task argument must
keep its string type and not be re-typed into a List.
**Remaining source feedback.** The remaining source blockers still apply at
`c6a6c730`. Could you reply with a short status (fixed, not yet, or disagree
with a reason) for each of the other earlier points?
- Placeholder validation errors echo raw default values, raw `-i` values and
surrounding config text before desensitization.
- The tightened `isStructured` demotes valid HOCON objects without a
top-level `:`/`=` to plain Strings.
- System sink placeholders such as `${table_name}` are subject to the new
with/without-default consistency check.
- Quoted default values keep their literal double quotes.
- The `processPlaceholders` Javadoc declares `IllegalArgumentException`, but
the method throws `ConfigException.BadValue`; `hasOnlyOnePlaceholder`,
`checkNotResolvedDefaultValue` and `parseStructured` have no Javadoc.
- `checkNotResolvedDefaultValue` swallows every non-`NotResolved` exception,
and the shared message says "Structured default value" for the plain-string
branch too.
- The new EN doc bullet links to the Chinese connector/transform docs, and
the preceding bullet has broken markdown.
**CI.** The Build check (run 132060561090) reports "Action required", which
is a workflow gate, not a test result. There is no need to change the
configuration code to clear it. Please keep the next revision focused on the
source feedback above, then link the Build run for that exact head once it runs.
<!-- streview-comment:2417 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]