SEZ9 commented on PR #12810:
URL: https://github.com/apache/seatunnel/pull/12810#issuecomment-6889209858

   Quick follow-up on where this stands from my side.
   
   **Agreed on the quoted `-i` string typing (PR12810-F1).** A quoted `-i` 
argument must stay a String; today it is re-typed into a List, which 
contradicts the documented disambiguation rule. Please keep the string type 
hint through the re-typing step and add a test covering the quoted-regex case.
   
   **Still open from the previous round** (please address or reply inline on 
each):
   - F2: placeholder validation errors echo raw default values, raw `-i` values 
and surrounding config text, and these are printed to the CLI/job log before 
desensitization. Please redact or omit the raw values.
   - F3: the tightened `isStructured` demotes valid HOCON objects without a 
top-level `:`/`=` to plain Strings, regressing phase-1 `-i` Map injection.
   - F4: system sink placeholders (`${table_name}`, `${database_name}`, ...) 
are now subject to the with/without-default consistency check, so existing 
multi-sink configs that mix the two forms fail at load time. Please exempt them 
or relax the check.
   - F5: quoted default values keep their literal double quotes; the documented 
migration form should yield the unquoted value.
   - F6: the `processPlaceholders` Javadoc declares `IllegalArgumentException` 
but the method throws `ConfigException.BadValue`; `hasOnlyOnePlaceholder`, 
`checkNotResolvedDefaultValue` and `parseStructured` need Javadoc.
   - F7: `checkNotResolvedDefaultValue` swallows every non-`NotResolved` 
exception, and the shared message says "Structured default value" even on the 
plain-string branch.
   - F8: the new EN doc bullet links to the Chinese connector/transform docs, 
and the preceding bullet has broken markdown (unbalanced `***`, missing space).
   
   **On CI:** the Apache Build check (run 132060561090) currently reports 
"Action required". That is a workflow gate, not a test failure, so please don't 
change the configuration code just to clear it; push the source fixes above and 
get Build running on the next revision.
   
   If any of F2–F8 were already fixed in a commit I haven't seen, point me to 
it and I'll re-check.
   
   <!-- streview-comment:2372 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to