SEZ9 commented on PR #11814:
URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-6962806047

   Thanks for the sync, @goutamadwant. Here is where each earlier point stands 
based on your update.
   
   **Covered by your update**
   - **Redirect restrictions (F7):** noted as already in the branch.
   - **Content-Type (F8):** the note beside the assertion explaining why no 
charset is appended is what was asked for.
   - **Kotlin stdlib (F4/F6):** noted as aligned at 1.9.10. Could you confirm 
`known-dependencies.txt` and the release `LICENSE` both show that single 
version after the merge with `dev`?
   
   **Still need confirmation**
   - **Close path (F2/F3):** do the cancellation/close guards cover these two 
cases?
     - When the scheduler fails to terminate, does `close()` skip the 
local-buffer flush rather than run it concurrently with the still-running task?
     - Are runtime failures other than 
`HazelcastInstanceNotActiveException`/`IOException` kept from escaping 
`close()`?
   - **E2E wait strategy (F1):** your update doesn't mention it. Is the wait on 
`received new worker register` now configured before the container starts, 
rather than in `executeExtraCommands`?
   - **`testRetryAfterHttpFailure` (F5):** also not mentioned. Does it now use 
a bounded `takeRequest` timeout, release the request buffers, and no longer 
rely on the scheduler firing immediately despite the 1-day interval?
   
   **Merge gate**
   The earlier approval and Build run 128488973591 were for 
`06a7b0ac4f416252b4234dd4f8af48d0e9f3b414`. The conflict resolution needs a 
fresh Build on the head you pushed, plus a check that the OkHttp/Okio 
relocations and the Hazelcast resource filter are both intact there.
   
   <!-- streview-comment:2419 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to