nchammas commented on code in PR #699: URL: https://github.com/apache/spark-website/pull/699#discussion_r4132086488
########## .github/workflows/html-build.yml: ########## @@ -0,0 +1,16 @@ +name: Build HTML + +on: + pull_request: + branches: + - asf-site + +jobs: + build: + name: Build HTML + runs-on: ubuntu-24.04 + steps: + - name: Checkout Spark Website repository Review Comment: The disk cleanup is not necessary. You can see that the build has been running on this PR just fine, and that includes a full checkout of the repo, including `site/`. The reason it runs fine is because there is ~90 GB of free space on a [150 GB disk][1] for the default public repo runners. This is different from the [14 GB][2] number shared in the docs. [1]: https://github.com/actions/runner-images/issues/14492#issuecomment-5191479879 [2]: https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories The nuance here is that the 150 GB disk is an official GitHub commitment for large runners only, not the regular runners we use: > We have no plans to reduce the 150 GB disk on 4-core runners back to 75 GB in the near future. That said, we can't guarantee it will stay that way forever. So this is working now and will likely work fine for the foreseeable future. That said, if you really want to future-proof this, we can either use a large runner (which I think needs ASF approval) or we can reintroduce some form of disk cleanup step. I personally don't think either is necessary for now, but I'm fine with any approach: a) do nothing; b) use large runner; c) create new composite action for disk cleanup and use it. @cloud-fan - What would you like to do? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
