cloud-fan commented on code in PR #699: URL: https://github.com/apache/spark-website/pull/699#discussion_r4129592874
########## .github/workflows/html-build.yml: ########## @@ -0,0 +1,16 @@ +name: Build HTML + +on: + pull_request: + branches: + - asf-site + +jobs: + build: + name: Build HTML + runs-on: ubuntu-24.04 + steps: + - name: Checkout Spark Website repository Review Comment: **Blocking (P1):** Both replacement jobs now make checkout their first substantive step, but the deleted job reclaimed large preinstalled packages before checking out this roughly 23 GiB tree. On the selected hosted runner, checkout can exhaust the available disk before either the PR build or the post-merge HTML job reaches the shared action. Please restore sufficient disk preparation ahead of checkout in both workflows, or use an equivalent checkout/storage design with demonstrated capacity. **Verification:** - **Inspection:** Verify that both affected job definitions place equivalent sufficient disk reclamation ahead of every checkout path. - **Behavior:** Verify representative pull-request and non-bot asf-site push executions can complete checkout and reach the shared HTML build on the selected hosted runner. ########## README.md: ########## @@ -1,10 +1,26 @@ -## Generating the website HTML +# Apache Spark Main Website -In this directory you will find text files formatted using Markdown, with an `.md` suffix. +This repository captures the main Apache Spark website located at https://spark.apache.org. The programming docs under https://spark.apache.org/docs/ are [in the main Spark repo][main], not here. They are built separately for each release of Spark and then copied to the website under the `docs/` directory. -Building the site requires [Ruby 3](https://www.ruby-lang.org), [Jekyll](http://jekyllrb.com/docs), and -[Rouge](https://github.com/rouge-ruby/rouge). The most reliable way to ensure a compatible environment -is to use the official Docker build image from the Apache Spark repository. +[main]: https://github.com/apache/spark/tree/master/docs#readme + +## Contributing + +To contribute changes, build and test the site locally, then submit a pull request with your changes. You only need to commit changes to the Markdown source. A [GitHub Actions workflow](.github/workflows/html-push.yml) will generate the corresponding HTML under `site/` and push it for you. Review Comment: Thanks, the current wording works for me: it says to commit source files, with Markdown only as the typical case, and leaves release-specific details in the release guide. <!-- SPARK_DEV_REVIEW_REPLY {"feedback_id":"inline:4084756263","thread_id":"inline:4084756263","verdict_sha256":"6bd43a4fdfe41283841a88738f8d9ccb60949376341836ff71d64a1309e5ced4"} --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
