cloud-fan commented on code in PR #699:
URL: https://github.com/apache/spark-website/pull/699#discussion_r4255832800


##########
.github/workflows/html-build.yml:
##########
@@ -0,0 +1,16 @@
+name: Build HTML
+
+on:
+  pull_request:
+    branches:
+    - asf-site
+
+jobs:
+  build:
+    name: Build HTML
+    runs-on: ubuntu-24.04
+    steps:
+    - name: Checkout Spark Website repository

Review Comment:
   Agreed, no change is needed here, and I'm withdrawing this blocker. The old 
doc_gen cleanup step had been a no-op since #610 removed the job container: it 
only deleted container tool-cache paths (`/__t/...`) and ran `apt-get remove` 
without sudo behind `|| true`. So the previous workflow already did a full 
checkout on the same ubuntu-24.04 runner with no effective cleanup, and this 
PR's Build HTML run confirms the checkout fits. If runner disk ever shrinks, a 
cleanup composite action can be added then.
   
   <!-- SPARK_DEV_REVIEW_REPLY 
{"feedback_id":"inline:4129592874","thread_id":"inline:4129592874","verdict_sha256":"c11bfeeddf7cc026662bfd0c3f66c22e6228daa904e1acedada7f11a2a439c7c"}
 -->



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to