cdmikechen commented on code in PR #985:
URL: https://github.com/apache/submarine/pull/985#discussion_r941327396
##########
submarine-cloud-v3/controllers/submarine_virtualservice.go:
##########
@@ -39,6 +39,7 @@ func (r *SubmarineReconciler) newSubmarineVirtualService(ctx
context.Context, su
r.Log.Error(err, "ParseVirtualService")
}
virtualService.Namespace = submarine.Namespace
+ virtualService.Spec.Hosts = append(virtualService.Spec.Hosts,
submarine.Namespace+".submarine")
Review Comment:
Is this `hosts` a necessary option?
If the user has deployed an ingress controller (e.g. nginx), my
understanding is that it should be possible for the user to define the hostname
themselves and configure some https certificate at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
