cdmikechen commented on code in PR #985:
URL: https://github.com/apache/submarine/pull/985#discussion_r944406961
##########
submarine-cloud-v3/controllers/submarine_virtualservice.go:
##########
@@ -39,6 +39,7 @@ func (r *SubmarineReconciler) newSubmarineVirtualService(ctx
context.Context, su
r.Log.Error(err, "ParseVirtualService")
}
virtualService.Namespace = submarine.Namespace
+ virtualService.Spec.Hosts = append(virtualService.Spec.Hosts,
submarine.Namespace+".submarine")
Review Comment:
@joshvictor1024
In that case, is it possible for us to add this configuration to the `Custom
Resource`?
Since `VirtualService` by istio is created by submarine operator, I think we
should also have the ability to configure it in CR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
