joshvictor1024 commented on code in PR #985:
URL: https://github.com/apache/submarine/pull/985#discussion_r941368271
##########
submarine-cloud-v3/controllers/submarine_virtualservice.go:
##########
@@ -39,6 +39,7 @@ func (r *SubmarineReconciler) newSubmarineVirtualService(ctx
context.Context, su
r.Log.Error(err, "ParseVirtualService")
}
virtualService.Namespace = submarine.Namespace
+ virtualService.Spec.Hosts = append(virtualService.Spec.Hosts,
submarine.Namespace+".submarine")
Review Comment:
I think this only acts as a default value. Users can re-define their
hostname using `kubectl edit` after the virtualservice is created. Is this ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
