joshvictor1024 commented on code in PR #985:
URL: https://github.com/apache/submarine/pull/985#discussion_r945235250
##########
submarine-cloud-v3/controllers/submarine_virtualservice.go:
##########
@@ -39,6 +39,7 @@ func (r *SubmarineReconciler) newSubmarineVirtualService(ctx
context.Context, su
r.Log.Error(err, "ParseVirtualService")
}
virtualService.Namespace = submarine.Namespace
+ virtualService.Spec.Hosts = append(virtualService.Spec.Hosts,
submarine.Namespace+".submarine")
Review Comment:
@cdmikechen This makes sense. I will add field `host` to the submarine CRD.
For a working default value (anything but `"*"`) to be assigned when creating
the CR in an arbitrary namespace, this field will be optional and default to
`<namespace>.submarine`. When a value is given, then that value overwrites the
default one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
