kenhuuu opened a new pull request, #3518:
URL: https://github.com/apache/tinkerpop/pull/3518
The server now applies per-request options set inside a submitted Gremlin
string's with(): evaluationTimeout/timeoutMillis, materializeProperties,
batchSize, bulkResults, and language, with a single precedence: script embedded
with() > request field > (header, bulkResults only) > default. This fixes a
regression where a script embedded timeoutMillis was silently ignored on the
raw string path.
Options are resolved once in Context; batchSize is parsed and validated
there, returning 400 Bad Request for a non positive or out of range value
rather than stalling result iteration or surfacing an uncaught 500. Validation
runs before any transaction begin side effects. g, parameters, and
transactionId remain request field/header only, and the obsolete requestId
scrape is removed from GremlinScriptChecker.
VOTE +1
<!--
Thanks for contributing! Reminders:
+ TARGET the earliest branch where you want the change
3.7-dev -> 3.7.7 (non-breaking only)
3.8-dev -> 3.8.2 (non-breaking only)
master -> 4.0.0
+ Committers will MERGE the PR forward to newer versions
+ ADD entry to the CHANGELOG.asciidoc for the targeted version
Do not reference a JIRA number there
+ ADD JIRA number to title and link in description
+ PRs requires 3 +1s from committers OR
1 +1 and 7 day wait to merge.
+ MORE details: https://s.apache.org/rtnal
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
