xiazcy commented on code in PR #3518:
URL: https://github.com/apache/tinkerpop/pull/3518#discussion_r3604790569
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinScriptChecker.java:
##########
@@ -178,7 +197,9 @@ public class GremlinScriptChecker {
Pattern.compile("\\.with\\((((?:"
+ timeoutTokens + "),(?<to>\\d*)(:?L|l)?)|((?:"
+ materializePropertiesTokens +
"),[\"'](?<mp>.*?)[\"']?)|((?:"
- + requestIdTokens + "),[\"'](?<rid>.*?)[\"']))\\)");
+ + languageTokens + "),[\"'](?<lang>.*?)[\"'])|((?:"
+ + batchSizeTokens + "),(?<bs>\\d+))|((?:"
Review Comment:
Confirming that we want the regex to ignore negative values here? I believe
this just silently drops the option when user puts a negative values like
`g.with('batchSize', -5)` (though not sure if anyone would) and falls back to
default. Just wondering if we want to explicitly capture negative values and
give error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
