xiazcy commented on code in PR #3518:
URL: https://github.com/apache/tinkerpop/pull/3518#discussion_r3604872338
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinScriptChecker.java:
##########
@@ -178,7 +197,9 @@ public class GremlinScriptChecker {
Pattern.compile("\\.with\\((((?:"
+ timeoutTokens + "),(?<to>\\d*)(:?L|l)?)|((?:"
+ materializePropertiesTokens +
"),[\"'](?<mp>.*?)[\"']?)|((?:"
- + requestIdTokens + "),[\"'](?<rid>.*?)[\"']))\\)");
+ + languageTokens + "),[\"'](?<lang>.*?)[\"'])|((?:"
+ + batchSizeTokens + "),(?<bs>\\d+))|((?:"
Review Comment:
I think falling to default makes sense for negative values, but perhaps we
should note it in the reference doc that if a user puts a negative value it'll
get ignored and falls to default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
