kenhuuu commented on code in PR #3518:
URL: https://github.com/apache/tinkerpop/pull/3518#discussion_r3605696921
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinScriptChecker.java:
##########
@@ -178,7 +197,9 @@ public class GremlinScriptChecker {
Pattern.compile("\\.with\\((((?:"
+ timeoutTokens + "),(?<to>\\d*)(:?L|l)?)|((?:"
+ materializePropertiesTokens +
"),[\"'](?<mp>.*?)[\"']?)|((?:"
- + requestIdTokens + "),[\"'](?<rid>.*?)[\"']))\\)");
+ + languageTokens + "),[\"'](?<lang>.*?)[\"'])|((?:"
+ + batchSizeTokens + "),(?<bs>\\d+))|((?:"
+ + bulkResultsTokens + "),(?<br>true|false)))\\)");
Review Comment:
I'm going to slightly loosen bulkResult only because something like
`g.with('bulkResults', 'someinvalidvalue')` gets interpreted as false because
of parseBooleans behavior. So its not quite right to completely loosen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
