Lunderberg commented on code in PR #16569:
URL: https://github.com/apache/tvm/pull/16569#discussion_r1507634901
##########
tests/python/tir-transform/test_tir_transform_lower_cross_thread_reduction.py:
##########
@@ -116,7 +116,8 @@ def no_normal_reduction(a: T.handle, b: T.handle) -> None:
B[vi] = B[vi] + A[vi, vk]
[email protected]_func
Review Comment:
Yeah, I think this pass pre-dates schedulable TIR, and doesn't check for
mapping of `ForNode::loop_var` to `BlockNode::iter_vars`. For now, I'd
probably just marked as ill-formed, to avoid expanding the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
