tqchen commented on code in PR #16756:
URL: https://github.com/apache/tvm/pull/16756#discussion_r1532262221
##########
include/tvm/relax/expr.h:
##########
@@ -823,11 +823,11 @@ class VarBindingNode : public BindingNode {
}
bool SEqualReduce(const VarBindingNode* other, SEqualReducer equal) const {
- return equal.DefEqual(var, other->var) && equal(value, other->value);
+ return equal(value, other->value) && equal.DefEqual(var, other->var);
Review Comment:
this might cause issue for self recursive definitions where the value can
refer to the var. We should cross check the current handling of lambda
expressions with self recursive reference, cc @slyubomirsky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
