slyubomirsky commented on code in PR #16756:
URL: https://github.com/apache/tvm/pull/16756#discussion_r1538419796
##########
src/relax/ir/expr.cc:
##########
@@ -384,6 +384,33 @@ TVM_REGISTER_GLOBAL("relax.MatchCast")
return MatchCast(var, value, struct_info, span);
});
+bool MatchCastNode::SEqualReduce(const MatchCastNode* other, SEqualReducer
equal) const {
+ if (value->IsInstance<FunctionNode>()) {
+ // Recursive function definitions may reference the bound variable
+ // within the value being bound. In these cases, the
+ // `DefEqual(var, other->var)` must occur first, to ensure it is
+ // defined at point of use.
+ return equal.DefEqual(var, other->var) && equal.DefEqual(struct_info,
other->struct_info) &&
Review Comment:
Per the above discussion, this sounds correct and indeed, local functions
are the only time a local var can be used recursively in Relax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
