Lunderberg commented on code in PR #16756:
URL: https://github.com/apache/tvm/pull/16756#discussion_r1534331758
##########
include/tvm/relax/expr.h:
##########
@@ -823,11 +823,11 @@ class VarBindingNode : public BindingNode {
}
bool SEqualReduce(const VarBindingNode* other, SEqualReducer equal) const {
- return equal.DefEqual(var, other->var) && equal(value, other->value);
+ return equal(value, other->value) && equal.DefEqual(var, other->var);
Review Comment:
Sounds good. I've added a unit test to ensure that recursively-defined
lambda functions can be correctly compared. This unit test passes on `main`,
failed on the first implementation as you pointed out, and now passes again
with the handling of lambda functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
