Lunderberg commented on code in PR #16756:
URL: https://github.com/apache/tvm/pull/16756#discussion_r1533141713
##########
include/tvm/relax/expr.h:
##########
@@ -823,11 +823,11 @@ class VarBindingNode : public BindingNode {
}
bool SEqualReduce(const VarBindingNode* other, SEqualReducer equal) const {
- return equal.DefEqual(var, other->var) && equal(value, other->value);
+ return equal(value, other->value) && equal.DefEqual(var, other->var);
Review Comment:
Good point. Are there any cases other than function definitions where the
value can contain references to the bound variable? I think the highlighting
of the RHS of a let binding is worth having a special case for lambda
functions, but wouldn't want to have too many special cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
