tqchen commented on a change in pull request #5601: URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r428729913
########## File path: include/tvm/runtime/c_runtime_api.h ########## @@ -114,6 +114,7 @@ typedef enum { kTVMNNVMLast = 20U, // The following section of code is used for non-reserved types. kTVMExtReserveEnd = 64U, + kTVMBFloat = 65U, Review comment: I don't think you will `kTVMBFloat` to support this feature. The kDLBFloat flag in the runtime::DataType should be sufficient for NDArray contents(because the type code in the NDArray contents diverges from the TVM type code above the OpaqueHandle). ########## File path: include/tvm/runtime/c_runtime_api.h ########## @@ -114,6 +114,7 @@ typedef enum { kTVMNNVMLast = 20U, // The following section of code is used for non-reserved types. kTVMExtReserveEnd = 64U, + kTVMBFloat = 65U, Review comment: I don't think you will `kTVMBFloat` to support this feature. The kDLBFloat flag in the runtime::DataType should be sufficient for NDArray contents(because the runtime::DataType's type code in the NDArray contents diverges from the TVM type code above the OpaqueHandle). ########## File path: include/tvm/runtime/c_runtime_api.h ########## @@ -114,6 +114,7 @@ typedef enum { kTVMNNVMLast = 20U, // The following section of code is used for non-reserved types. kTVMExtReserveEnd = 64U, + kTVMBFloat = 65U, Review comment: I don't think you will `kTVMBFloat` to support this feature. The DataType::kDLBFloat flag in the runtime::DataType should be sufficient for NDArray contents(because the runtime::DataType's type code in the NDArray contents diverges from the TVM type code above the OpaqueHandle). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org