[GitHub] [incubator-tvm] ZhennanQin commented on a change in pull request #5601: [TVM Core] Add bfloat16

[GitBox]

ZhennanQin commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r428480499



##########
File path: src/target/llvm/codegen_llvm.cc
##########
@@ -309,6 +309,9 @@ llvm::Type* CodeGenLLVM::DTypeToLLVMType(const DataType& 
dtype) const {
       default:
         LOG(FATAL) << "do not support " << dtype;
     }
+  } else if (dtype.is_bfloat()) {
+    CHECK_EQ(dtype.bits(), 16);

Review comment:
       A good question. Will we treat TensorFloat-32 as bfloat20? If so, then 
`bits` is useful to distinguish those.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org