jroesch commented on a change in pull request #6162:
URL: https://github.com/apache/incubator-tvm/pull/6162#discussion_r463206316
##########
File path: src/parser/parser.cc
##########
@@ -542,39 +496,60 @@ class Parser {
*/
template <typename T>
Array<T> ParseSequence(TokenType start, TokenType sep, TokenType stop,
std::function<T()> parse,
- std::function<void()> before_stop = nullptr) {
+ std::function<bool()> before_stop = nullptr) {
+ DLOG(INFO) << "Parser::ParseSequence: start=" << start << "sep=" << sep <<
"stop=" << stop;
Review comment:
Why not use DLOG? if anything we should be increasing logging in TVM not
removing it. There has been more talk of doing increased structured logging
after I finish doing error reporting but there is no RFC at the current time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
