jroesch commented on a change in pull request #6162:
URL: https://github.com/apache/incubator-tvm/pull/6162#discussion_r463855404
##########
File path: src/parser/parser.cc
##########
@@ -542,39 +496,60 @@ class Parser {
*/
template <typename T>
Array<T> ParseSequence(TokenType start, TokenType sep, TokenType stop,
std::function<T()> parse,
- std::function<void()> before_stop = nullptr) {
+ std::function<bool()> before_stop = nullptr) {
+ DLOG(INFO) << "Parser::ParseSequence: start=" << start << "sep=" << sep <<
"stop=" << stop;
Review comment:
We could potentially use the diagnostics to log some information, but I
think that is a bigger change that requires more design, my goal is to first
convert all user visible errors. Happy to revisit this in a few PRs as the
current changes are already roughly 4-6kloc of code and I still haven't even
converted the pass manager or pass context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
