jroesch commented on a change in pull request #6162: URL: https://github.com/apache/incubator-tvm/pull/6162#discussion_r463856185
########## File path: include/tvm/parser/source_map.h ########## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#ifndef TVM_PARSER_SOURCE_MAP_H_ +#define TVM_PARSER_SOURCE_MAP_H_ +/*! + * \file source_map.h + * \brief A map from source names to source code. + */ +#include <tvm/runtime/packed_func.h> +#include <tvm/runtime/registry.h> +#include <tvm/ir/span.h> + +#include <fstream> +#include <string> + +namespace tvm { +namespace parser { + + +/*! \brief A program source in any language. + * + * Could represent the source from an ML framework or the internal + * source of a TVM program. + */ +struct Source { + /*! \brief The raw source. */ + std::string source; + /*! \brief A mapping of line breaks into the raw source. */ + std::vector<std::pair<int, int>> line_map; + + /*! \brief An empty source. */ + Source() : source(), line_map() {} + + /*! \brief Construct a source from a string. */ + TVM_DLL explicit Source(const std::string& source); + + TVM_DLL Source(const Source& source) : source(source.source), line_map(source.line_map) {} + + /*! \brief Generate an error message at a specific line and column with the + * annotated message. + * + * The error is written directly to the `out` std::ostream. + * + * \param out The output ostream. + * \param line The line at which to report a diagnostic. + * \param line The column at which to report a diagnostic. + * \param msg The message to attach. + */ + TVM_DLL void ReportAt(std::ostream& out, int line, int column, const std::string& msg) const; +}; + +/*! + * \brief A mapping from a unique source name to source fragment. + */ +class SourceMap; Review comment: I wanted to split out all the source_map management into a logic header to me its distinct from the spans, if anything I would put span's into source_map.h as they are really just indicies into a source file. I was also attempting to keep the less stable interface in the parser headers for now as parser/diagnostics will evolve quickly. Once we are happy with the interface we can stabilize by lifting to the top-level include directory. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
