leandron commented on a change in pull request #6342:
URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r478273962
##########
File path: docker/Dockerfile.ci_cpu
##########
@@ -83,3 +83,7 @@ RUN bash /install/ubuntu_install_caffe.sh
# Github Arm(R) Ethos(TM)-N NPU driver
COPY install/ubuntu_install_ethosn_driver_stack.sh
/install/ubuntu_install_ethosn_driver_stack.sh
RUN bash /install/ubuntu_install_ethosn_driver_stack.sh
+
+# Vitis-AI PyXIR CI deps
+COPY install/ubuntu_install_vai_packages.sh
/install/ubuntu_install_vai_packages.sh
+RUN bash /install/ubuntu_install_vai_packages.sh
Review comment:
> Also, as this script is only used for CI I think
`ubuntu_install_vitis_ai_packages_ci.sh` would be better. What do you think?
I had a look on your other PR now, and I understand what you said about the
other script. I think it would be beneficial to have all the CI change in one
patch, if possible.
##########
File path: docker/Dockerfile.ci_cpu
##########
@@ -83,3 +83,7 @@ RUN bash /install/ubuntu_install_caffe.sh
# Github Arm(R) Ethos(TM)-N NPU driver
COPY install/ubuntu_install_ethosn_driver_stack.sh
/install/ubuntu_install_ethosn_driver_stack.sh
RUN bash /install/ubuntu_install_ethosn_driver_stack.sh
+
+# Vitis-AI PyXIR CI deps
+COPY install/ubuntu_install_vai_packages.sh
/install/ubuntu_install_vai_packages.sh
+RUN bash /install/ubuntu_install_vai_packages.sh
Review comment:
> Also, as this script is only used for CI I think
`ubuntu_install_vitis_ai_packages_ci.sh` would be better. What do you think?
I had a look on your other PR now, and I understand what you said about the
other script. I think it would be beneficial to have all the CI change in one
patch, if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
