leandron commented on a change in pull request #6342:
URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r478288536
##########
File path: docker/Dockerfile.ci_cpu
##########
@@ -83,3 +83,7 @@ RUN bash /install/ubuntu_install_caffe.sh
# Github Arm(R) Ethos(TM)-N NPU driver
COPY install/ubuntu_install_ethosn_driver_stack.sh
/install/ubuntu_install_ethosn_driver_stack.sh
RUN bash /install/ubuntu_install_ethosn_driver_stack.sh
+
+# Vitis-AI PyXIR CI deps
+COPY install/ubuntu_install_vai_packages.sh
/install/ubuntu_install_vai_packages.sh
+RUN bash /install/ubuntu_install_vai_packages.sh
Review comment:
> Should we rename the ci_vai to make it more clear that it's our main
docker environment and it's not really for CI at the moment?
I think it would be good to name it in a way that is obvious to people on
what that Dockerfile is intended for. Looking at existing Dockerfiles
(https://github.com/apache/incubator-tvm/tree/master/docker) I see there are
three prefixes: `ci_*`, `conda_*` and `demo_`. Maybe from the repository point
of view it fits more for a `demo` than `ci`? I'm not very sure about what the
right answer here, maybe @tqchen will know better.
> Should we add it to this PR even though it's meant to be used for CI?
Even not being strictly related to CI, as @comaniac pointed out, it is
related to environment changes (for example the change/fix on the
`ubuntu_install_python.sh` that might affect other Dockerfiles). So I think it
would be good to have them all in one PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
