areusch commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r530584966
##########
File path: include/tvm/ir/module.h
##########
@@ -56,11 +56,14 @@ class IRModuleNode : public Object {
Map<GlobalTypeVar, TypeData> type_definitions;
/*! \brief The source map for the module. */
parser::SourceMap source_map;
+ /*! \brief The names of external functions for func registry */
+ Array<String> ext_func_names;
Review comment:
@zhiics I think i see what's happening here: with the c++ runtime on
full OS, codegen could generate symbols from a variety of modules and rely on
runtime lookup via dlsym. with C runtime which has no dlsym, we use a
FuncRegistry which is currently generated inside the host module. this has led
to the need for "model-level" metadata being passed to the codegen in a couple
of cases. probably the right thing to do is move FuncRegistry to its own module
and pass this metadata there?
##########
File path: python/tvm/runtime/module.py
##########
@@ -268,6 +268,11 @@ def export_library(self, file_name, fcompile=None,
addons=None, **kwargs):
If fcompile has attribute object_format, will compile host library
to that format. Otherwise, will use default format "o".
+ workspace_dir : str, optional
+ The name of the workspace dir to create intermediary
+ artifacts for the process exporting of the library.
+ If this is not provided a temporary dir will be created.
+
kwargs : dict, optional
Additional arguments passed to fcompile
"""
Review comment:
document the return type
##########
File path: python/tvm/micro/build.py
##########
@@ -162,7 +158,12 @@ def build_static_runtime(
libs.append(compiler.library(lib_build_dir, lib_srcs, lib_opts))
- libs.append(compiler.library(mod_build_dir, [mod_src_path],
generated_lib_opts))
+ libs.append(
Review comment:
cool, I don't mind this approach
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
