areusch commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r530632362



##########
File path: include/tvm/ir/module.h
##########
@@ -56,11 +56,14 @@ class IRModuleNode : public Object {
   Map<GlobalTypeVar, TypeData> type_definitions;
   /*! \brief The source map for the module. */
   parser::SourceMap source_map;
+  /*! \brief The names of external functions for func registry */
+  Array<String> ext_func_names;

Review comment:
       I think the issue with metadata module is that it assumes it is just 
generating the data for storage rather than immediate consumption on the target 
device. it requires a load process that ultimately copies the data into RAM. we 
want to avoid this at all cost on µTVM, because RAM is most precious. so I 
think we either would need to modify metadatamodule to enforce alignment or 
create something else.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to