areusch commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r532779368
##########
File path: include/tvm/ir/module.h
##########
@@ -56,11 +56,14 @@ class IRModuleNode : public Object {
Map<GlobalTypeVar, TypeData> type_definitions;
/*! \brief The source map for the module. */
parser::SourceMap source_map;
+ /*! \brief The names of external functions for func registry */
+ Array<String> ext_func_names;
Review comment:
@manupa-arm that also seems reasonable to me. one question though--do
you still intend to keep FuncRegistry codegen as-is (i.e. would you still
generate the same global symbols)? it would be nice to avoid worrying about
alignment issues for global symbols if we are generating C.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
