masahi commented on a change in pull request #8105:
URL: https://github.com/apache/tvm/pull/8105#discussion_r641009417
##########
File path: python/tvm/relay/op/transform.py
##########
@@ -1087,6 +1087,10 @@ def gather_nd(data, indices, batch_dims=0):
batch_dims : int
The number of batch dimensions.
+ num_indices_per_tuple : int
+ The size of an indexing tuple, which is a fixed value and the same as
indices.shape[0]
+ Only needed when other dimensions of indices are dynamic.
Review comment:
It is not significant. Having a default value at call sites means this
value is not explicitly set, which is an error for dynamic workload. The
negative value is only for catching an error at
https://github.com/apache/tvm/blob/55a4430f507d801b7441e60d00f06c8161aea30a/python/tvm/relay/op/_transform.py#L1106.
This value is not optional either, since this is required for dynamic
workloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
