jwfromm commented on a change in pull request #8105:
URL: https://github.com/apache/tvm/pull/8105#discussion_r641094140
##########
File path: include/tvm/relay/attrs/transform.h
##########
@@ -146,11 +146,18 @@ struct GatherAttrs : public tvm::AttrsNode<GatherAttrs> {
struct GatherNDAttrs : public tvm::AttrsNode<GatherNDAttrs> {
Integer batch_dims;
+ Integer num_indices_per_tuple;
TVM_DECLARE_ATTRS(GatherAttrs, "relay.attrs.GatherNDAttrs") {
TVM_ATTR_FIELD(batch_dims).set_default(Integer(0)).describe("The number of
batch dimensions.");
+ TVM_ATTR_FIELD(num_indices_per_tuple)
Review comment:
yeah thats fair, I personally think `index_rank` makes a little more
sense but am fine either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
