jwfromm commented on a change in pull request #8105:
URL: https://github.com/apache/tvm/pull/8105#discussion_r641093560
##########
File path: python/tvm/relay/op/transform.py
##########
@@ -1087,6 +1087,10 @@ def gather_nd(data, indices, batch_dims=0):
batch_dims : int
The number of batch dimensions.
+ num_indices_per_tuple : int
+ The size of an indexing tuple, which is a fixed value and the same as
indices.shape[0]
+ Only needed when other dimensions of indices are dynamic.
Review comment:
Would it be inconvenient to make the default value `None` (indicating
that it won't be used / the input must be static) instead of `-1`? That would
be more consistent with the behavior and less confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
