masahi commented on a change in pull request #8105:
URL: https://github.com/apache/tvm/pull/8105#discussion_r641012378



##########
File path: include/tvm/relay/attrs/transform.h
##########
@@ -146,11 +146,18 @@ struct GatherAttrs : public tvm::AttrsNode<GatherAttrs> {
 
 struct GatherNDAttrs : public tvm::AttrsNode<GatherNDAttrs> {
   Integer batch_dims;
+  Integer num_indices_per_tuple;
 
   TVM_DECLARE_ATTRS(GatherAttrs, "relay.attrs.GatherNDAttrs") {
     TVM_ATTR_FIELD(batch_dims).set_default(Integer(0)).describe("The number of 
batch dimensions.");
+    TVM_ATTR_FIELD(num_indices_per_tuple)

Review comment:
       Also I'd like to think that this attributes was added to workaround the 
current Relay limitation I described, ideally it should go away when we have a 
better representation of runtime shape in relay...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to