tmoreau89 commented on a change in pull request #32:
URL: https://github.com/apache/tvm-vta/pull/32#discussion_r701571315
##########
File path: hardware/dpi/tsim_device.cc
##########
@@ -58,19 +60,25 @@ void VTAHostDPI(dpi8_t* req_valid,
resp_valid, resp_value);
}
-void VTAMemDPI(dpi8_t req_valid,
- dpi8_t req_opcode,
- dpi8_t req_len,
- dpi64_t req_addr,
+void VTAMemDPI(dpi8_t rd_req_valid,
+ dpi8_t rd_req_len,
+ dpi8_t rd_req_id,
Review comment:
tabs/spacing is off
##########
File path: hardware/dpi/tsim_device.cc
##########
@@ -58,19 +60,25 @@ void VTAHostDPI(dpi8_t* req_valid,
resp_valid, resp_value);
}
-void VTAMemDPI(dpi8_t req_valid,
- dpi8_t req_opcode,
- dpi8_t req_len,
- dpi64_t req_addr,
+void VTAMemDPI(dpi8_t rd_req_valid,
+ dpi8_t rd_req_len,
+ dpi8_t rd_req_id,
+ dpi64_t rd_req_addr,
+ dpi8_t wr_req_valid,
+ dpi8_t wr_req_len,
+ dpi64_t wr_req_addr,
dpi8_t wr_valid,
- dpi64_t wr_value,
+ const svOpenArrayHandle wr_value,
+ dpi64_t wr_strb,
dpi8_t* rd_valid,
- dpi64_t* rd_value,
+ dpi8_t* rd_id,
Review comment:
tabs/spacing is off
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
