manupa-arm commented on a change in pull request #8914:
URL: https://github.com/apache/tvm/pull/8914#discussion_r702368083
##########
File path: include/tvm/ir/module.h
##########
@@ -122,6 +122,7 @@ class IRModuleNode : public Object {
v->Visit("global_var_map_", &global_var_map_);
v->Visit("global_type_var_map_", &global_type_var_map_);
v->Visit("source_map", &source_map);
+ v->Visit("attrs", &attrs);
Review comment:
After having checked :
https://github.com/apache/tvm/blob/9f52e7e3fcb3e607e51b584437857a118fb74609/src/relay/backend/te_compiler.cc#L890-L906
I dont think it is transferred.
##########
File path: include/tvm/ir/module.h
##########
@@ -122,6 +122,7 @@ class IRModuleNode : public Object {
v->Visit("global_var_map_", &global_var_map_);
v->Visit("global_type_var_map_", &global_type_var_map_);
v->Visit("source_map", &source_map);
+ v->Visit("attrs", &attrs);
Review comment:
I think this is a very important change and should be called out in the
PR title or the main description.
What happens to these when they are split to Map<Target, IRModule> in
lowered_funcs or per_target_module in the intepretter ? Are they copied in ?
Will it be possible to add a test to make sure attrs are passed onto TIR
lowering ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
