electriclilies commented on a change in pull request #8914:
URL: https://github.com/apache/tvm/pull/8914#discussion_r703725918
##########
File path: src/relay/backend/te_compiler.cc
##########
@@ -918,33 +918,15 @@ Map<Target, IRModule> GetPerTargetModules(IRModule mod) {
return per_target_modules;
}
-IRModule GetMainModule(IRModule mod) {
- IRModule main_module;
- // Copy the type defs
- for (const auto& kv : mod->type_definitions) {
- main_module->AddTypeDef(kv.first, kv.second);
- }
- // Copy all Relay functions (we don't include PrimFuncs)
- for (auto kv : mod->functions) {
- const GlobalVar& var = kv.first;
- const BaseFunc& func = kv.second;
- if (func->IsInstance<tvm::relay::FunctionNode>()) {
- main_module->Add(var, func);
- }
- }
- return main_module;
-}
-
Pass LowerTEPass(TargetMap targets, DeviceMap device_context_map,
backend::StaticMemoryPlan memory_plan, const String&
module_name,
std::function<void(Function)> process_fn) {
runtime::TypedPackedFunc<IRModule(IRModule, PassContext)> pass_func =
[=](IRModule module,
PassContext ctx) {
return LowerTE(module, targets, device_context_map, memory_plan,
module_name, process_fn);
};
- // TODO(@electriclilies, mbs): Fold InferType() pass into LowerTEPass since
it will always need to
- // be called afterwards
- return tvm::transform::CreateModulePass(pass_func, 1, "LowerTE", {});
+ return tvm::transform::Sequential(
+ {tvm::transform::CreateModulePass(pass_func, 1, "LowerTE", {}),
InferType()});
Review comment:
Cool, thanks for catching this! I'll add a note to that test about not
removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
